[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[jfw] Re: The future of Joomla\Application\Client

Does anyone have any thoughts or suggestions?
I would vote for the alternative solution you suggested (standalone package), because I would say that the Joomla community is much more active than any 3rd party solution and browser detection is a continuous job.

I did not check https://github.com/gabrielbull/php-browser but the https://github.com/Ikimea/Browser class looks like a solution based on the work from Gary White (http://www.apptools.com/phptools/browser) mentioned in this repo https://github.com/cbschuld/Browser.php which I would go for instead of the Ikimea repo if using a 3rd party one.

On Thursday, 19 March 2015 03:49:25 UTC+1, George Wilson wrote:
Dear All,
Joomla\Application\Client is a weird beast. It's a browser detection library - but one that detects only the most common browsers and engines, also not using a good API (relying on getting all properties of the browser via Client::__get()). Generally this makes it pretty inflexible for use by people who want to use it in everyday scenarios. I'm sure we are all aware it's predecessor JBrowser (https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/environment/browser.php) in the CMS which was much more complete in browsers recognized but proved extremely hard to maintain.

To that end I started investigating moving away from Client and moving towards a 3rd party solution we could import with composer. The two most promising options I could find were https://github.com/gabrielbull/php-browser  and https://github.com/Ikimea/Browser. Whilst both solutions are acceptable in terms of browsers covered they do not cover the browser engine. This is important because we need an explicit check for the Trident engine in our own Joomla\Application\Web::redirect() method.

The alternative to a 3rd party solution is we expand our checks back towards how we found things in JBrowser with a more complete selection of browsers and move it into it's own standalone package that the Application package can import as a competitive solution to other products.

Does anyone have any thoughts or suggestions?

Kind Regards,

Framework source code: https://github.com/joomla-framework
Visit http://developer.joomla.org for more information about developing with Joomla!
You received this message because you are subscribed to the Google Groups "Joomla! Framework Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to joomla-dev-framework+unsubscribe AT googlegroups.com.
Visit this group at http://groups.google.com/group/joomla-dev-framework.