Not even taking the CMS into consideration (even though that's why we've been looking at this), I'd say revert and make it consistent. I get why it was done but as is it's a partial solution that should've been caught much sooner. In 2.0, we can drop the reference for all.
On Friday, September 5, 2014, George Wilson <georgeja...@googlemail.
com> wrote:Hi all,--So as we know there are severe issues getting the input package into the CMS. Largely because the $_REQUEST in the input package is not passed by reference, whereas it is in the CMS (see this PR for the change) https://github.com/ eddieajau/joomla-framework/ commit/ 58dc9f93adddbb4aa145273b81c197 05cf70aa44Whilst the change is good it means that we can't fix alias in the CMS and also we have inconsistencies as the $_COOKIES is still passed by reference (see https://github.com/ joomla-framework/input/blob/) as well as $_FILES (https://github.com/joomla- master/src/Cookie.php#L40 framework/input/blob/master/). src/Files.php#L49We can't remove the passing by reference in the CMS as that is a b/c break. So what I propose is to readd the passing of $_REQUEST by reference into v1.0 of the framework. Then for v2.0 we remove ALL calls by reference. Changing to fit the CMS for v1.0 and then immediately reverting said change in 2.0 is NOT unprecedented (see https://github.com/joomla- framework/registry/commit/). b9b8058fafad9cdb046d26821bb291 12a709fa0aAny feedback on that proposed change is welcomeKind Regards,George
Framework source code: https://github.com/joomla-
Visit http://developer.joomla.org for more information about developing with Joomla!
You received this message because you are subscribed to the Google Groups "Joomla! Framework Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to joomla-dev-framework+
unsubscribe AT googlegroups.com.
Visit this group at http://groups.google.com/
Please pardon any errors, this message was sent from my iPhone.