[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[jfw] Review JSession Test setUp



// TODO: This code logic appears useless, many missing methods are being called.  Review.
        parent
::setUp();
        $this
->saveFactoryState();
        $this
->object = JSession::getInstance('none', array('expire' => 20, 'force_ssl' => true, 'name' => 'name', 'id' => 'id', 'security' => 'security'));
        $this
->input = new JInput;
        $this
->input->cookie = $this->getMock('JInputCookie', array('set', 'get'));
        $this
->object->initialise($this->input);
        $this
->input->cookie->expects($this->any())
           
->method('set');
        $this
->input->cookie->expects($this->any())
           
->method('get')
           
->will($this->returnValue(null));
        $this
->object->start();

The question is why not use native cookie methods? To begin with, JInput is not used, and is not at all loaded using composer.

--
Framework source code: https://github.com/joomla/joomla-framework
Visit http://developer.joomla.org for more information about developing with Joomla!
---
You received this message because you are subscribed to the Google Groups "Joomla! Framework Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to joomla-dev-framework+unsubscribe AT googlegroups.com.
Visit this group at http://groups.google.com/group/joomla-dev-framework.